Changeset 1293

Show
Ignore:
Timestamp:
03/31/08 16:44:01 (8 months ago)
Author:
sandal
Message:

Making Table#rename_column fail silently

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • ruport/trunk/Rakefile

    r1238 r1293  
    3434                       '--main'  << 'README' << '-q' 
    3535  spec.add_dependency('fastercsv', '>= 1.1.0') 
    36   spec.add_dependency('pdf-writer', '= 1.1.7') 
     36  spec.add_dependency('pdf-writer', '= 1.1.8') 
    3737  spec.author = "Gregory Brown" 
    3838  spec.email = "  gregory.t.brown@gmail.com" 
  • ruport/trunk/lib/ruport/data/table.rb

    r1287 r1293  
    527527    # 
    528528    def rename_column(old_name,new_name) 
    529       self.column_names[column_names.index(old_name)] = new_name 
     529      index = column_names.index(old_name) or return 
     530      self.column_names[index] = new_name 
    530531      each { |r| r.rename_attribute(old_name,new_name,false)}  
    531532    end 
  • ruport/trunk/test/table_test.rb

    r1286 r1293  
    663663  end  
    664664 
     665  def test_ensure_renaming_a_missing_column_fails_silently 
     666    a = Table(%w[a b c]) 
     667    assert_nothing_raised do 
     668      a.rename_column("d", "z") 
     669    end 
     670  end 
     671 
    665672end   
    666673