Ticket #382 (new defect)

Opened 9 months ago

Last modified 9 months ago

Possible issue with render_inline_grouping

Reported by: brian Assigned to:
Milestone: ruport 1.4 defects Keywords: render inline grouping output buffer newline
Cc:

Description

Not entirely sure this is a bug, but looking at the following code in formatter.rb: 

      def render_inline_grouping(options={},&block)
        data.each do |_,group|
          render_group(group, options, &block)
          output << "\n"
        end
      end

It's the 'output << "\n"' that bothers me, because this method is called from formatter/pdf.rb (in method build_grouping_body)

Does it cause problems to append a newline to the output buffer when rendering a (binary) PDF? Or does it not matter in practice?

Change History

02/11/08 16:01:34 changed by brian

P.S. Personally I would prefer CSV output not to have this extra blank line between groups, and it doesn't make any difference for HTML, so perhaps this ought to move into the text formatter only?

02/20/08 08:56:10 changed by sandal

Please don't use the tracker for discussing problems. Post a link to the ticket to ruport-dev instead.

03/03/08 20:55:33 changed by sandal

  • milestone changed from ruport 1.4 changes to ruport 1.4 defects.

Milestone ruport 1.4 changes deleted